linux-kernel - Re:[PATCH v2 03/34] drm/bridge: analogix-anx6345: convert to devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45fac756.a42e.1967c5fd015.Coremail.andyshrk@163.com>
Date: Mon, 28 Apr 2025 20:29:36 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
	"Maxime Ripard" <mripard@...nel.org>,
	"Thomas Zimmermann" <tzimmermann@...e.de>,
	"David Airlie" <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>,
	"Andrzej Hajda" <andrzej.hajda@...el.com>,
	"Neil Armstrong" <neil.armstrong@...aro.org>,
	"Robert Foss" <rfoss@...nel.org>,
	"Laurent Pinchart" <Laurent.pinchart@...asonboard.com>,
	"Jonas Karlman" <jonas@...boo.se>,
	"Jernej Skrabec" <jernej.skrabec@...il.com>,
	"Jagan Teki" <jagan@...rulasolutions.com>,
	"Shawn Guo" <shawnguo@...nel.org>,
	"Sascha Hauer" <s.hauer@...gutronix.de>,
	"Pengutronix Kernel Team" <kernel@...gutronix.de>,
	"Fabio Estevam" <festevam@...il.com>,
	"Douglas Anderson" <dianders@...omium.org>,
	"Chun-Kuang Hu" <chunkuang.hu@...nel.org>,
	"Krzysztof Kozlowski" <krzk@...nel.org>,
	"Anusha Srivatsa" <asrivats@...hat.com>,
	"Paul Kocialkowski" <paulk@...-base.io>,
	"Dmitry Baryshkov" <lumag@...nel.org>,
	"Hui Pu" <Hui.Pu@...ealthcare.com>,
	"Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
	dri-devel@...ts.freedesktop.org, asahi@...ts.linux.dev,
	linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	linux-amlogic@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	freedreno@...ts.freedesktop.org,
	linux-stm32@...md-mailman.stormreply.com,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	"Andy Yan" <andy.yan@...k-chips.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com>,
	"Jani Nikula" <jani.nikula@...el.com>,
	"Sui Jingfeng" <sui.jingfeng@...ux.dev>
Subject: Re:[PATCH v2 03/34] drm/bridge: analogix-anx6345: convert to
 devm_drm_bridge_alloc() API


Hi,

At 2025-04-25 02:59:10, "Luca Ceresoli" <luca.ceresoli@...tlin.com> wrote:
>This is the new API for allocating DRM bridges.
>
>Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Reviewed-by: Andy Yan <andyshrk@....com>

>
>---
>
>Cc: "Uwe Kleine-König" <u.kleine-koenig@...libre.com>
>Cc: Andy Yan <andy.yan@...k-chips.com>
>Cc: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>Cc: Jani Nikula <jani.nikula@...el.com>
>Cc: Sui Jingfeng <sui.jingfeng@...ux.dev>
>---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
>index f2bafa6cf77956ecafc87aae3a2b6890bdb36cfa..f3fe47b12edca1f92ddd306d152be144df5649b5 100644
>--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
>+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
>@@ -664,9 +664,10 @@ static int anx6345_i2c_probe(struct i2c_client *client)
> 	struct device *dev;
> 	int i, err;
> 
>-	anx6345 = devm_kzalloc(&client->dev, sizeof(*anx6345), GFP_KERNEL);
>-	if (!anx6345)
>-		return -ENOMEM;
>+	anx6345 = devm_drm_bridge_alloc(&client->dev, struct anx6345, bridge,
>+					&anx6345_bridge_funcs);
>+	if (IS_ERR(anx6345))
>+		return PTR_ERR(anx6345);
> 
> 	mutex_init(&anx6345->lock);
> 
>@@ -738,7 +739,6 @@ static int anx6345_i2c_probe(struct i2c_client *client)
> 	/* Look for supported chip ID */
> 	anx6345_poweron(anx6345);
> 	if (anx6345_get_chip_id(anx6345)) {
>-		anx6345->bridge.funcs = &anx6345_bridge_funcs;
> 		drm_bridge_add(&anx6345->bridge);
> 
> 		return 0;
>
>-- 
>2.49.0
>