linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: Add rk3399-evb-ind board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15ee1a6b-55ba-41e9-b8a0-6e0bf62cabf0@lunn.ch>
Date: Mon, 28 Apr 2025 14:45:47 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Chaoyi Chen <chaoyi.chen@...k-chips.com>
Cc: Chaoyi Chen <kernel@...kyi.com>, Heiko Stuebner <heiko@...ech.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Jonas Karlman <jonas@...boo.se>,
	Kever Yang <kever.yang@...k-chips.com>,
	Jianfeng Liu <liujianfeng1994@...il.com>,
	Dragan Simic <dsimic@...jaro.org>,
	Jimmy Hon <honyuenkwun@...il.com>,
	Quentin Schulz <quentin.schulz@...rry.de>,
	FUKAUMI Naoki <naoki@...xa.com>,
	Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
	Alexey Charkov <alchark@...il.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add rk3399-evb-ind board

On Mon, Apr 28, 2025 at 09:47:34AM +0800, Chaoyi Chen wrote:
> Hi Andrew,
> 
> On 2025/4/28 4:42, Andrew Lunn wrote:
> > > +&gmac {
> > > +	assigned-clocks = <&cru SCLK_RMII_SRC>;
> > > +	assigned-clock-parents = <&clkin_gmac>;
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&rgmii_pins>;
> > > +	clock_in_out = "input";
> > > +	phy-supply = <&vcc_phy>;
> > > +	phy-mode = "rgmii";
> > Does the PCB have extra long clock lines to implement the RGMII 2ns
> > delay?
> The 2ns delay of RGMII is implemented inside the RK3399 chip instead of PCB
> lines, and there are also additional delayline configurations.

If the PCB does not implement the delay, rgmii is wrong.

If the MAC/PHY pair is implementing the delay, you need to use
rgmii-id. You can then use additional properties to fine tune the
delay the MAC/PHY is adding. And the Linux preference is that the PHY
adds the delay.

	Andrew