linux-kernel - Re: [PATCH 3/6] f2fs: drop usage of folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMgjq7A-mO0vs3ZX1m9i+dPSuSURwJUWL-03dMzGbbwkj_mHjA@mail.gmail.com>
Date: Mon, 28 Apr 2025 10:15:28 +0800
From: Kairui Song <ryncsn@...il.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>, 
	David Hildenbrand <david@...hat.com>, Hugh Dickins <hughd@...gle.com>, Chris Li <chrisl@...nel.org>, 
	Yosry Ahmed <yosryahmed@...gle.com>, "Huang, Ying" <ying.huang@...ux.alibaba.com>, 
	Nhat Pham <nphamcs@...il.com>, Johannes Weiner <hannes@...xchg.org>, linux-kernel@...r.kernel.org, 
	Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>, 
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 3/6] f2fs: drop usage of folio_index

On Mon, Apr 28, 2025 at 8:41 AM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Mon, Apr 28, 2025 at 02:59:05AM +0800, Kairui Song wrote:
> > folio_index is only needed for mixed usage of page cache and swap
> > cache, for pure page cache usage, the caller can just use
> > folio->index instead.
> >
> > It can't be a swap cache folio here.  Swap mapping may only call into fs
> > through `swap_rw` and that is not supported for f2fs.  So just drop it
> > and use folio->index instead.
> >
> > Signed-off-by: Kairui Song <kasong@...cent.com>
> > Cc: Jaegeuk Kim <jaegeuk@...nel.org> (maintainer:F2FS FILE SYSTEM)
> > Cc: Chao Yu <chao@...nel.org> (maintainer:F2FS FILE SYSTEM)
> > Cc: linux-f2fs-devel@...ts.sourceforge.net (open list:F2FS FILE SYSTEM)
> > Signed-off-by: Kairui Song <kasong@...cent.com>
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
>
> > @@ -130,7 +130,7 @@ int f2fs_read_inline_data(struct inode *inode, struct folio *folio)
> >               return -EAGAIN;
> >       }
> >
> > -     if (folio_index(folio))
> > +     if (folio->index)
> >               folio_zero_segment(folio, 0, folio_size(folio));
> >       else
> >               f2fs_do_read_inline_data(folio, ipage);
>
> This hunk is going to conflict with a pair of patches I sent to f2fs-devel
> a few weeks ago.  I don't think there's any escaping it, just a heads-up.
>

Thanks for the info, this patch is just converting folio_index to
folio->index so conflict should be easy to resolve I think? I can do a
rebase later if that series is merged first.