linux-kernel - Re: [PATCH net V3] amd-xgbe: Fix to ensure dependent features are toggled with RX checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250428125424.GC3339421@horms.kernel.org>
Date: Mon, 28 Apr 2025 13:54:24 +0100
From: Simon Horman <horms@...nel.org>
To: Vishal Badole <Vishal.Badole@....com>
Cc: Shyam-sundar.S-k@....com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	Thomas.Lendacky@....com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Raju.Rangoju@....com,
	stable@...r.kernel.org
Subject: Re: [PATCH net V3] amd-xgbe: Fix to ensure dependent features are
 toggled with RX checksum offload

On Thu, Apr 24, 2025 at 06:32:48PM +0530, Vishal Badole wrote:
> According to the XGMAC specification, enabling features such as Layer 3
> and Layer 4 Packet Filtering, Split Header and Virtualized Network support
> automatically selects the IPC Full Checksum Offload Engine on the receive
> side.
> 
> When RX checksum offload is disabled, these dependent features must also
> be disabled to prevent abnormal behavior caused by mismatched feature
> dependencies.
> 
> Ensure that toggling RX checksum offload (disabling or enabling) properly
> disables or enables all dependent features, maintaining consistent and
> expected behavior in the network device.
> 
> v2->v3:
> -------
> - Removed RSS feature toggling as checksum offloading functions correctly
> without it
> 
> v1->v2:
> -------
> - Combine 2 patches into a single patch
> - Update the "Fix: tag"
> - Add necessary changes to support earlier versions of the hardware as well

Hi Vishal,

I don't think there is any need to resend because of this.
But, for future reference, these days it is preferred to put changelog
information, such as the above two paragraphs, below the scissors ("---").

This way they are present in mailing list archives and so on.
But are omitted from git history (because the patch description is
truncated at the scissors).

> 
> Cc: stable@...r.kernel.org
> Fixes: 1a510ccf5869 ("amd-xgbe: Add support for VXLAN offload capabilities")
> Signed-off-by: Vishal Badole <Vishal.Badole@....com>
> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-desc.c |  9 +++++++--
>  drivers/net/ethernet/amd/xgbe/xgbe-dev.c  | 24 +++++++++++++++++++++--
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c  | 11 +++++++++--
>  drivers/net/ethernet/amd/xgbe/xgbe.h      |  4 ++++
>  4 files changed, 42 insertions(+), 6 deletions(-)

Reviewed-by: Simon Horman <horms@...nel.org>