linux-kernel - Re: [PATCH net-next] tipc: Replace msecs_to_jiffies() with secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <183272C9-A50F-427D-8492-A474E72E97E0@linux.dev>
Date: Mon, 28 Apr 2025 15:23:43 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Tung Quang Nguyen <tung.quang.nguyen@....tech>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "tipc-discussion@...ts.sourceforge.net" <tipc-discussion@...ts.sourceforge.net>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Jon Maloy <jmaloy@...hat.com>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] tipc: Replace msecs_to_jiffies() with
 secs_to_jiffies()

On 28. Apr 2025, at 04:31, Tung Quang Nguyen wrote:
>> Use secs_to_jiffies() instead of msecs_to_jiffies() and avoid scaling 'delay' to
>> milliseconds in tipc_crypto_rekeying_sched(). Compared to msecs_to_jiffies(),
>> secs_to_jiffies() expands to simpler code and reduces the size of 'tipc.ko'.
> I observed an opposite result after applying your patch, an increasement of 320 bytes.
> Before patch:
> 969392 Apr 28 08:53 tipc.ko
> 
> After patch:
> 969712 Apr 28 09:11 tipc.ko

Which architecture and config did you use?

For x86_64 using LLVM, defconfig, and CONFIG_TIPC=m I get 929960 bytes
before and 929864 bytes after my patch, so 96 bytes less than before.

For arm64 using LLVM, defconfig, and CONFIG_TIPC=m, I get 8005616 bytes
before and 8005304 bytes after my patch, so 312 bytes less than before.

Thanks,
Thorsten