linux-kernel - Re: [PATCH] fs/netfs/read_collect: remove duplicate line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a83bf0565fccbe448ab1a350def86f91@manguebit.com>
Date: Mon, 28 Apr 2025 10:38:39 -0300
From: Paulo Alcantara <pc@...guebit.com>
To: Max Kellermann <max.kellermann@...os.com>, dhowells@...hat.com,
 netfs@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: Max Kellermann <max.kellermann@...os.com>
Subject: Re: [PATCH] fs/netfs/read_collect: remove duplicate line

Paulo Alcantara <pc@...guebit.com> writes:

> Max Kellermann <max.kellermann@...os.com> writes:
>
>> @@ -653,7 +653,6 @@ ssize_t netfs_wait_for_read(struct netfs_io_request *rreq)
>>  		switch (rreq->origin) {
>>  		case NETFS_DIO_READ:
>>  		case NETFS_READ_SINGLE:
>> -			ret = rreq->transferred;
>>  			break;
>>  		default:
>>  			if (rreq->submitted < rreq->len) {
>
> This is wrong.  @ret is expected to have the amount of bytes
> successfully read if no error.

Err, sorry.  I just saw the assignment right after if (ret == 0) check.

Looks good,

Reviewed-by: Paulo Alcantara (Red Hat) <pc@...guebit.com>