linux-kernel - Re: [PATCH] arm64: dts: amlogic: gxl: set i2c bias to pull-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef96c3a2-f1ab-4615-8f7f-43050718e2df@amlogic.com>
Date: Mon, 28 Apr 2025 10:36:45 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Da Xue <da@...re.computer>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: gxl: set i2c bias to pull-up

Hi Martin,

On 2025/4/28 05:08, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
> 
> On Fri, Apr 25, 2025 at 10:31 PM Da Xue <da@...re.computer> wrote:
>>
>> GXL I2C pins need internal pull-up enabled to operate if there
>> is no external resistor. The pull-up is 60kohms per the datasheet.
>>
>> We should set the bias when i2c pinmux is enabled.
>>
>> Signed-off-by: Da Xue <da@...re.computer>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> +Xianwei Zhao (who has recently upstreamed Amlogic A4 pinctrl support).
> I suspect we need a similar change for all other (Meson8, Meson8b,
> GXBB, G12A, ...) SoCs as well.
> Can you confirm this? And if not, why does only GXL need this special treatment?
> 

The A4 pinctrl driver mainly differs in the implementation method, and 
the differences between chips are primarily described in the DTS, rather 
than requiring the submission of bindings and code each time a new SoC 
pinctrl driver support is added. In theory, previous chips could also be 
supported by new drivers.

> 
> Best regards,
> Martin