linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: chemical: Document SEN0322

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9463c3b0-ce67-4c67-a8e9-91b4ffd09a58@kernel.org>
Date: Mon, 28 Apr 2025 16:30:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: gomba007@...il.com, Jonathan Cameron <jic23@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: chemical: Document SEN0322

On 28/04/2025 12:50, Tóth János via B4 Relay wrote:
> +
> +description: >
> +  DFRobot SEN0322 is an oxygen sensor. It supports I2C for communication.
> +
> +  Datasheet:
> +    https://wiki.dfrobot.com/Gravity_I2C_Oxygen_Sensor_SKU_SEN0322
> +
> +properties:
> +  compatible:
> +    const: dfrobot,sen0322
> +
> +  reg:
> +    maxItems: 1

No other properties like supplies or configuration? If so, this could go
to trivial-devices.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      sen0322@73 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Choose something from above or similar devices.



Best regards,
Krzysztof