linux-kernel - Re: [PATCH v2 6/6] mm, swap: remove no longer used swap mapping helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f12086b6-8a24-40b6-8c6d-75131e0e2573@redhat.com>
Date: Tue, 29 Apr 2025 14:24:29 +0200
From: David Hildenbrand <david@...hat.com>
To: Kairui Song <kasong@...cent.com>, linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Matthew Wilcox <willy@...radead.org>, Hugh Dickins <hughd@...gle.com>,
 Chris Li <chrisl@...nel.org>, Yosry Ahmed <yosryahmed@...gle.com>,
 "Huang, Ying" <ying.huang@...ux.alibaba.com>, Nhat Pham <nphamcs@...il.com>,
 Johannes Weiner <hannes@...xchg.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] mm, swap: remove no longer used swap mapping
 helper

On 29.04.25 13:49, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> This helper existed to fix the circular header dependency issue
> but it is no longer used since commit 0d40cfe63a2f ("fs: remove
> folio_file_mapping()"), remove it.
> 
> Signed-off-by: Kairui Song <kasong@...cent.com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>   include/linux/pagemap.h | 1 -
>   mm/swapfile.c           | 9 ---------
>   2 files changed, 10 deletions(-)
> 
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 47b5746d5a65..a071cdc8f902 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -533,7 +533,6 @@ static inline void filemap_nr_thps_dec(struct address_space *mapping)
>   }
>   
>   struct address_space *folio_mapping(struct folio *);
> -struct address_space *swapcache_mapping(struct folio *);
>   
>   /**
>    * folio_flush_mapping - Find the file mapping this folio belongs to.
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index bf6c98009909..1a36e1f4f198 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -3653,15 +3653,6 @@ struct swap_info_struct *swp_swap_info(swp_entry_t entry)
>   	return swap_type_to_swap_info(swp_type(entry));
>   }
>   
> -/*
> - * out-of-line methods to avoid include hell.
> - */
> -struct address_space *swapcache_mapping(struct folio *folio)
> -{
> -	return swp_swap_info(folio->swap)->swap_file->f_mapping;
> -}
> -EXPORT_SYMBOL_GPL(swapcache_mapping);
> -
>   /*
>    * add_swap_count_continuation - called when a swap count is duplicated
>    * beyond SWAP_MAP_MAX, it allocates a new page and links that to the entry's

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb