linux-kernel - Re: [PATCH] staging: rtl8723bs: Replace manual mutex handling with scoped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025042905-enunciate-sixfold-bd3f@gregkh>
Date: Tue, 29 Apr 2025 14:25:25 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Erick Karanja <karanja99erick@...il.com>
Cc: julia.lawall@...ia.fr, philipp.g.hortmann@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Replace manual mutex handling with
 scoped_guard()

On Tue, Apr 29, 2025 at 03:05:13PM +0300, Erick Karanja wrote:
> This refactor replaces manual mutex lock/unlock with scoped_guard()
> in places where early exits use goto. Using scoped_guard()
> avoids error-prone unlock paths and simplifies control flow.

Again, for new code, this is fine.  But don't add it to old stuff unless
you really have a good reason to do so.

Unless you have the hardware and can test that your change was correct.
Do you have such hardware and was it tested?

thanks,

greg k-h