linux-kernel - Re: [PATCH] usb: gadget: hid: allow dynamic interval configuration via configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025042944-velvet-underwire-e0f5@gregkh>
Date: Tue, 29 Apr 2025 15:48:24 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: hoff.benjamin.k@...il.com
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: hid: allow dynamic interval configuration
 via configfs

On Tue, Apr 29, 2025 at 09:33:10AM -0400, hoff.benjamin.k@...il.com wrote:
> From: Ben Hoff <hoff.benjamin.k@...il.com>
> 
> This patch adds support for dynamically configuring the polling interval
> (bInterval) for HID function drivers using configfs. This enables
> custom HID gadgets with user-specified poll rates without recompilation.

But you changed the default from:

> -	.bInterval		= 4, /* FIXME: Add this field in the
> -				      * HID gadget configuration?
> -				      * (struct hidg_func_descriptor)
> -				      */

 to:
 
> +	opts->interval = 10;

do you mean to do that without documenting it?

thanks,

greg k-h