linux-kernel - RE: [PATCH 6.1.y v2] net/sched: act_mirred: don't override retval if we already lost the skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR11MB61703A24C42BAA887F5263ACBB802@IA1PR11MB6170.namprd11.prod.outlook.com>
Date: Tue, 29 Apr 2025 02:07:54 +0000
From: "Ren, Jianqi (Jacky) (CN)" <Jianqi.Ren.CN@...driver.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com"
	<xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "michal.swiatkowski@...ux.intel.com" <michal.swiatkowski@...ux.intel.com>,
        "He, Zhe" <Zhe.He@...driver.com>
Subject: RE: [PATCH 6.1.y v2] net/sched: act_mirred: don't override retval if
 we already lost the skb

Hello,
I have already dropped the first v2 patch for incorrect comments(Maybe you missed the dropping email). This v2 patch is just I want to send. Thanks!

-----Original Message-----
From: Greg KH <gregkh@...uxfoundation.org> 
Sent: Monday, April 28, 2025 19:46
To: Ren, Jianqi (Jacky) (CN) <Jianqi.Ren.CN@...driver.com>
Cc: stable@...r.kernel.org; patches@...ts.linux.dev; linux-kernel@...r.kernel.org; jhs@...atatu.com; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org; michal.swiatkowski@...ux.intel.com; He, Zhe <Zhe.He@...driver.com>
Subject: Re: [PATCH 6.1.y v2] net/sched: act_mirred: don't override retval if we already lost the skb

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

On Mon, Apr 28, 2025 at 04:01:03PM +0800, jianqi.ren.cn@...driver.com wrote:
> From: Jakub Kicinski <kuba@...nel.org>
>
> [ Upstream commit 166c2c8a6a4dc2e4ceba9e10cfe81c3e469e3210 ]
>
> If we're redirecting the skb, and haven't called tcf_mirred_forward(), 
> yet, we need to tell the core to drop the skb by setting the retcode 
> to SHOT. If we have called tcf_mirred_forward(), however, the skb is 
> out of our hands and returning SHOT will lead to UaF.
>
> Move the retval override to the error path which actually need it.
>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Fixes: e5cf1baf92cb ("act_mirred: use TC_ACT_REINSERT when possible")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: David S. Miller <davem@...emloft.net> [Minor conflict 
> resolved due to code context change.]
> Signed-off-by: Jianqi Ren <jianqi.ren.cn@...driver.com>
> Signed-off-by: He Zhe <zhe.he@...driver.com>
> ---
> v2: Fix the following issue
> net/sched/act_mirred.c:265:6: error: variable 'is_redirect' is used 
> uninitialized whenever 'if' condition is true found by the following 
> tuxmake
> (https://lore.kernel.org/stable/CA+G9fYu+FEZ-3ye30Hk2sk1+LFsw7iO5AHueU
> a9H1Ub=JO-k2g@...l.gmail.com/) Verified the build test by cmd(tuxmake 
> --runtime podman --target-arch arm  --toolchain clang-20 --kconfig 
> allmodconfig LLVM=1 LLVM_IAS=1)

I see 2 "v2" patches here, both different, so I'm dropping both of them :(