linux-kernel - Re: [PATCH v3] perf test probe_vfs_getname: Skip if no suitable line detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBDp9fU5qJJeP9z3@x1>
Date: Tue, 29 Apr 2025 12:02:13 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Jakub Brnak <jbrnak@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>, kan.liang@...ux.intel.com,
	mpetlan@...hat.com, tglozar@...hat.com,
	Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH v3] perf test probe_vfs_getname: Skip if no suitable line
 detected

On Thu, Apr 10, 2025 at 01:58:35PM -0700, Namhyung Kim wrote:
> Hello,
> 
> On Thu, Apr 10, 2025 at 04:32:11PM +0200, Jakub Brnak wrote:
> > On Mon, Mar 24, 2025 at 03:45:23PM +0100, Jakub Brnak wrote:
> > > In some cases when calling function add_probe_vfs_getname, line number
> > > can't be detected by perf probe -L getname_flags:
> > > 
> > >   78         atomic_set(&result->refcnt, 1);
> > > 
> > > 	     // one of the following lines should have line number
> > > 	     // but sometimes it does not because of optimization
> > > 	     result->uptr = filename;
> > >              result->aname = NULL;
> > > 
> > >   81         audit_getname(result);
> > > 
> > > To prevent false failures, skip the affected tests
> > > if no suitable line numbers can be detected.
> > > 
> > > Signed-off-by: Jakub Brnak <jbrnak@...hat.com>
> 
> Sorry for the long delay.  It looks ok to me.
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, applied to perf-tools-next,

- Arnaldo