linux-kernel - Re: [PATCH] ASoC: Intel: catpt: avoid type mismatch in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82d02705-46d1-4748-99e1-be80c06644fc@intel.com>
Date: Tue, 29 Apr 2025 17:26:25 +0200
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Arnd Bergmann <arnd@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, Jaroslav Kysela <perex@...ex.cz>, "Takashi
 Iwai" <tiwai@...e.com>, <linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Liam Girdwood
	<liam.r.girdwood@...ux.intel.com>, Peter Ujfalusi
	<peter.ujfalusi@...ux.intel.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Kai Vehmanen
	<kai.vehmanen@...ux.intel.com>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] ASoC: Intel: catpt: avoid type mismatch in dev_dbg()
 format

On 2025-04-29 9:35 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Depending on the architecture __ffs() returns either an 'unsigned long'
> or 'unsigned int' result. Compile-testing this driver on targets that
> use the latter produces a warning:
> 
> sound/soc/intel/catpt/dsp.c: In function 'catpt_dsp_set_srampge':
> sound/soc/intel/catpt/dsp.c:181:44: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Werror=format=]
>    181 |                         dev_dbg(cdev->dev, "sanitize block %ld: off 0x%08x\n",
>        |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Change the type of the local variable to match the format string and
> avoid the warning on any architecture.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   sound/soc/intel/catpt/dsp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/catpt/dsp.c b/sound/soc/intel/catpt/dsp.c
> index 5993819cc58a..008a20a2acbd 100644
> --- a/sound/soc/intel/catpt/dsp.c
> +++ b/sound/soc/intel/catpt/dsp.c
> @@ -156,7 +156,7 @@ static void catpt_dsp_set_srampge(struct catpt_dev *cdev, struct resource *sram,
>   {
>   	unsigned long old;
>   	u32 off = sram->start;
> -	u32 b = __ffs(mask);
> +	unsigned long b = __ffs(mask);
>   
>   	old = catpt_readl_pci(cdev, VDRTCTL0) & mask;
>   	dev_dbg(cdev->dev, "SRAMPGE [0x%08lx] 0x%08lx -> 0x%08lx",

Thank you for this contribution, LGTM.

Acked-by: Cezary Rojewski <cezary.rojewski@...el.com>