linux-kernel - Re: [PATCH v2] ACPI: PCI: Release excess memory usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <538f8456-1b28-4e7b-83ae-71b4c4ebcf8b@web.de>
Date: Tue, 29 Apr 2025 17:56:21 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhe Qiao <qiaozhe@...as.ac.cn>, linux-acpi@...r.kernel.org,
 linux-pci@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, Len Brown <lenb@...nel.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Sunil V L
 <sunilvl@...tanamicro.com>, Will Deacon <will@...nel.org>
Subject: Re: [PATCH v2] ACPI: PCI: Release excess memory usage

…
> +++ b/drivers/pci/pci-acpi.c
> @@ -1677,15 +1677,12 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
>  
>  	root_ops = kzalloc(sizeof(*root_ops), GFP_KERNEL);
>  	if (!root_ops) {
> -		kfree(ri);
> -		return NULL;
> +		goto free_ri;
>  	}

Would you like to omit curly brackets around a single statement?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.15-rc4#n197

Regards,
Markus