[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=V3LsgMkVyUo9ZNq7VBZgRzX-7hVSyvVGXSA7Woyu-R1w@mail.gmail.com>
Date: Tue, 29 Apr 2025 09:27:09 -0700
From: Doug Anderson <dianders@...omium.org>
To: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drm/panel-edp: Add support for CSW MNE007QS3-8 panel
Hi,
On Tue, Apr 29, 2025 at 2:20 AM Zhengqiao Xia
<xiazhengqiao@...qin.corp-partner.google.com> wrote:
>
> CSW MNE007QS3-8 EDID:
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 0e 77 57 14 00 00 00 00
> 34 22 01 04 a5 1e 13 78 07 ee 95 a3 54 4c 99 26
> 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 cd 7c 80 a0 70 b0 50 40 30 20
> 26 04 2e bc 10 00 00 1a cd 7c 80 a0 70 b0 50 45
> 30 20 26 04 2e bc 10 00 00 1a 00 00 00 fd 00 1e
> 78 9a 9a 20 01 0a 20 20 20 20 20 20 00 00 00 fc
> 00 4d 4e 45 30 30 37 51 53 33 2d 38 0a 20 01 3f
>
> 70 20 79 02 00 21 00 1d c8 0b 5d 07 80 07 b0 04
> 80 3d 8a 54 cd a4 99 66 62 0f 02 45 54 7c 5d 7c
> 5d 00 43 12 78 2b 00 0c 27 00 1e 77 00 00 27 00
> 1e 3b 00 00 2e 00 06 00 43 7c 5d 7c 5d 81 00 20
> 74 1a 00 00 03 01 1e 78 00 00 5a ff 5a ff 78 00
> 00 00 00 8d 00 e3 05 04 00 e6 06 01 01 5a 5a ff
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 76 90
>
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
nit: your Signed-off-by should have been _below_ my Reviewed-by. In
general whenever you send a patch you always move your Signed-off-by
to the bottom of all the other tags. No need to resend this time, but
keep in mind for the future.
nit: this is unchanged from v2 when Dmitry added his review on the
cover letter. You probably should have carried forward his tag. No
need to resend this time, but keep in mind for the future. I've
re-added it.
Pushed to drm-misc-next:
[3/3] drm/panel-edp: Add support for CSW MNE007QS3-8 panel
commit: 0d607a59a0f6593e72630854a8bcb8b01b8dce40
Powered by blists - more mailing lists