linux-kernel - Re: [PATCH] firmware_loader: use SHA-256 library API instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250429164223.GB1743@sol.localdomain>
Date: Tue, 29 Apr 2025 09:42:23 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Luis Chamberlain <mcgrof@...nel.org>,
	Russ Weight <russ.weight@...ux.dev>,
	Danilo Krummrich <dakr@...nel.org>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>,
	Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>
Subject: Re: [PATCH] firmware_loader: use SHA-256 library API instead of
 crypto_shash API

On Tue, Apr 29, 2025 at 07:54:42AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 28, 2025 at 12:09:09PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > This user of SHA-256 does not support any other algorithm, so the
> > crypto_shash abstraction provides no value.  Just use the SHA-256
> > library API instead, which is much simpler and easier to use.
> > 
> > Also take advantage of printk's built-in hex conversion using %*phN.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > ---
> > 
> > This patch is targeting the firmware_loader tree for 6.16.
> 
> 
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Greg, it looks like you normally take patches to this file.  You can go ahead
and take it if you want.  Thanks!

- Eric