linux-kernel - [PATCH v3 2/2] x86/panic: Add x86_panic_handler as default post-panic behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250429150638.1446781-3-carlos.bilbao@kernel.org>
Date: Tue, 29 Apr 2025 10:06:38 -0500
From: carlos.bilbao@...nel.org
To: tglx@...utronix.de,
	seanjc@...gle.com,
	jan.glauber@...il.com
Cc: bilbao@...edu,
	pmladek@...e.com,
	akpm@...ux-foundation.org,
	jani.nikula@...el.com,
	linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org,
	takakura@...inux.co.jp,
	john.ogness@...utronix.de,
	Carlos Bilbao <carlos.bilbao@...nel.org>
Subject: [PATCH v3 2/2] x86/panic: Add x86_panic_handler as default post-panic behavior

From: Carlos Bilbao <carlos.bilbao@...nel.org>

Add function x86_panic_handler() as the default behavior for x86 for
post-panic stage via panic_set_handling(). Instead of busy-wait loop, it
will halt if there's no console to save CPU cycles.

Signed-off-by: Carlos Bilbao (DigitalOcean) <carlos.bilbao@...nel.org>
Reviewed-by: Jan Glauber (DigitalOcean) <jan.glauber@...il.com>
---
 arch/x86/kernel/setup.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9d2a13b37833..abca4a9b5e0a 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -16,6 +16,7 @@
 #include <linux/initrd.h>
 #include <linux/iscsi_ibft.h>
 #include <linux/memblock.h>
+#include <linux/panic.h>
 #include <linux/panic_notifier.h>
 #include <linux/pci.h>
 #include <linux/root_dev.h>
@@ -837,6 +838,20 @@ static void __init x86_report_nx(void)
 	}
 }
 
+/*
+ * Halt the CPU to save resources after panic is handled. If
+ * console_trylock() succeeds, no other CPU is currently writing to the
+ * console
+ *
+ */
+static void x86_panic_handler(void)
+{
+	if (console_trylock()) {
+		console_unlock();
+		safe_halt();
+	}
+}
+
 /*
  * Determine if we were loaded by an EFI loader.  If so, then we have also been
  * passed the efi memmap, systab, etc., so we should use these data structures
@@ -1252,6 +1267,8 @@ void __init setup_arch(char **cmdline_p)
 #endif
 
 	unwind_init();
+
+	panic_set_handling(x86_panic_handler, 0);
 }
 
 #ifdef CONFIG_X86_32
-- 
2.47.1