| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <810dc089-4789-4efb-a88f-4ab8da1519d4@nxp.com> Date: Tue, 29 Apr 2025 10:19:27 +0800 From: Liu Ying <victor.liu@....com> To: Luca Ceresoli <luca.ceresoli@...tlin.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Jagan Teki <jagan@...rulasolutions.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Douglas Anderson <dianders@...omium.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org> Cc: Anusha Srivatsa <asrivats@...hat.com>, Paul Kocialkowski <paulk@...-base.io>, Dmitry Baryshkov <lumag@...nel.org>, Hui Pu <Hui.Pu@...ealthcare.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, dri-devel@...ts.freedesktop.org, asahi@...ts.linux.dev, linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-renesas-soc@...r.kernel.org, platform-driver-x86@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org, linux-stm32@...md-mailman.stormreply.com, Adam Ford <aford173@...il.com>, Adrien Grassein <adrien.grassein@...il.com>, Aleksandr Mishin <amishin@...rgos.ru>, Andy Yan <andy.yan@...k-chips.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Benson Leung <bleung@...omium.org>, Biju Das <biju.das.jz@...renesas.com>, Christoph Fritz <chf.fritz@...glemail.com>, Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, Detlev Casanova <detlev.casanova@...labora.com>, Dharma Balasubiramani <dharma.b@...rochip.com>, Guenter Roeck <groeck@...omium.org>, Heiko Stuebner <heiko@...ech.de>, Jani Nikula <jani.nikula@...el.com>, Janne Grunau <j@...nau.net>, Jerome Brunet <jbrunet@...libre.com>, Jesse Van Gavere <jesseevg@...il.com>, Kevin Hilman <khilman@...libre.com>, Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, Manikandan Muralidharan <manikandan.m@...rochip.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Matthias Brugger <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, Phong LE <ple@...libre.com>, Sasha Finkelstein <fnkl.kernel@...il.com>, Sugar Zhang <sugar.zhang@...k-chips.com>, Sui Jingfeng <sui.jingfeng@...ux.dev>, Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Vitalii Mordan <mordan@...ras.ru> Subject: Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API Hi, On 04/25/2025, Luca Ceresoli wrote: > devm_drm_bridge_alloc() is the new API to be used for allocating (and > partially initializing) a private driver struct embedding a struct > drm_bridge. > > For many drivers having a simple code flow in the probe function, this > commit does a mass conversion automatically with the following semantic > patch. The changes have been reviewed manually for correctness as well as > to find any false positives. > > @@ > type T; > identifier C; > identifier BR; > expression DEV; > expression FUNCS; > @@ > -T *C; > +T *C; > ... > ( > -C = devm_kzalloc(DEV, ...); > -if (!C) > - return -ENOMEM; > +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS); > +if (IS_ERR(C)) > + return PTR_ERR(C); > | > -C = devm_kzalloc(DEV, ...); > -if (!C) > - return ERR_PTR(-ENOMEM); > +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS); > +if (IS_ERR(C)) > + return PTR_ERR(C); > ) > ... > -C->BR.funcs = FUNCS; > > Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com> > > --- > > Cc: Adam Ford <aford173@...il.com> > Cc: Adrien Grassein <adrien.grassein@...il.com> > Cc: Aleksandr Mishin <amishin@...rgos.ru> > Cc: Andy Yan <andy.yan@...k-chips.com> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> > Cc: Benson Leung <bleung@...omium.org> > Cc: Biju Das <biju.das.jz@...renesas.com> > Cc: Christoph Fritz <chf.fritz@...glemail.com> > Cc: Cristian Ciocaltea <cristian.ciocaltea@...labora.com> > Cc: Detlev Casanova <detlev.casanova@...labora.com> > Cc: Dharma Balasubiramani <dharma.b@...rochip.com> > Cc: Guenter Roeck <groeck@...omium.org> > Cc: Heiko Stuebner <heiko@...ech.de> > Cc: Jani Nikula <jani.nikula@...el.com> > Cc: Janne Grunau <j@...nau.net> > Cc: Jerome Brunet <jbrunet@...libre.com> > Cc: Jesse Van Gavere <jesseevg@...il.com> > Cc: Kevin Hilman <khilman@...libre.com> > Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com> > Cc: Liu Ying <victor.liu@....com> > Cc: Manikandan Muralidharan <manikandan.m@...rochip.com> > Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com> > Cc: Matthias Brugger <matthias.bgg@...il.com> > Cc: Philipp Zabel <p.zabel@...gutronix.de> > Cc: Phong LE <ple@...libre.com> > Cc: Sasha Finkelstein <fnkl.kernel@...il.com> > Cc: Sugar Zhang <sugar.zhang@...k-chips.com> > Cc: Sui Jingfeng <sui.jingfeng@...ux.dev> > Cc: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com> > Cc: Vitalii Mordan <mordan@...ras.ru> > > Changed in v2: > - added missing PTR_ERR() in the second spatch alternative > --- > drivers/gpu/drm/adp/adp-mipi.c | 8 ++++---- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 ++++----- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ++++----- > drivers/gpu/drm/bridge/aux-bridge.c | 9 ++++----- > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 9 +++++---- > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 8 ++++---- > drivers/gpu/drm/bridge/chipone-icn6211.c | 9 ++++----- > drivers/gpu/drm/bridge/chrontel-ch7033.c | 8 ++++---- > drivers/gpu/drm/bridge/cros-ec-anx7688.c | 9 ++++----- > drivers/gpu/drm/bridge/fsl-ldb.c | 7 +++---- > drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 9 ++++----- > drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 10 ++++------ > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 8 ++++---- > drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 8 ++++---- > drivers/gpu/drm/bridge/ite-it6263.c | 9 ++++----- > drivers/gpu/drm/bridge/ite-it6505.c | 9 ++++----- > drivers/gpu/drm/bridge/ite-it66121.c | 9 ++++----- > drivers/gpu/drm/bridge/lontium-lt8912b.c | 9 ++++----- > drivers/gpu/drm/bridge/lontium-lt9211.c | 8 +++----- > drivers/gpu/drm/bridge/lontium-lt9611.c | 9 ++++----- > drivers/gpu/drm/bridge/lvds-codec.c | 9 ++++----- > drivers/gpu/drm/bridge/microchip-lvds.c | 8 ++++---- > drivers/gpu/drm/bridge/nwl-dsi.c | 8 ++++---- > drivers/gpu/drm/bridge/parade-ps8622.c | 9 ++++----- > drivers/gpu/drm/bridge/parade-ps8640.c | 9 ++++----- > drivers/gpu/drm/bridge/sii9234.c | 9 ++++----- > drivers/gpu/drm/bridge/sil-sii8620.c | 9 ++++----- > drivers/gpu/drm/bridge/simple-bridge.c | 10 ++++------ > drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 8 ++++---- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 ++++---- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 8 ++++---- > drivers/gpu/drm/bridge/tc358762.c | 9 ++++----- > drivers/gpu/drm/bridge/tc358764.c | 9 ++++----- > drivers/gpu/drm/bridge/tc358768.c | 9 ++++----- > drivers/gpu/drm/bridge/tc358775.c | 9 ++++----- > drivers/gpu/drm/bridge/thc63lvd1024.c | 8 ++++---- > drivers/gpu/drm/bridge/ti-dlpc3433.c | 9 ++++----- > drivers/gpu/drm/bridge/ti-tdp158.c | 8 ++++---- > drivers/gpu/drm/bridge/ti-tfp410.c | 9 ++++----- > drivers/gpu/drm/bridge/ti-tpd12s015.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_dp.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_dsi.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 ++++----- > drivers/gpu/drm/meson/meson_encoder_cvbs.c | 12 ++++++------ > drivers/gpu/drm/meson/meson_encoder_dsi.c | 12 ++++++------ > drivers/gpu/drm/meson/meson_encoder_hdmi.c | 12 ++++++------ > drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 9 ++++----- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 10 ++++------ > 49 files changed, 201 insertions(+), 237 deletions(-) [...] > diff --git a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > index f072c6ed39ef183b10518b43bd6d979bc89e36f9..8069c4881e9058f5462f99116799b589bd52b19e 100644 > --- a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > +++ b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > @@ -59,9 +59,10 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev, > struct imx_legacy_bridge *imx_bridge; > int ret; > > - imx_bridge = devm_kzalloc(dev, sizeof(*imx_bridge), GFP_KERNEL); > - if (!imx_bridge) > - return ERR_PTR(-ENOMEM); > + imx_bridge = devm_drm_bridge_alloc(dev, struct imx_legacy_bridge, > + base, &imx_legacy_bridge_funcs); > + if (IS_ERR(imx_bridge)) > + return PTR_ERR(imx_bridge); > > ret = of_get_drm_display_mode(np, > &imx_bridge->mode, > @@ -71,8 +72,6 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev, > return ERR_PTR(ret); > > imx_bridge->mode.type |= DRM_MODE_TYPE_DRIVER; > - Nit: Can you please leave this blank line undeleted? And I see similar situations where lines are unnecessarily deleted by this patch, so this applies to the entire patch. > - imx_bridge->base.funcs = &imx_legacy_bridge_funcs; > imx_bridge->base.of_node = np; > imx_bridge->base.ops = DRM_BRIDGE_OP_MODES; > imx_bridge->base.type = type; -- Regards, Liu Ying
Powered by blists - more mailing lists