linux-kernel - Re: [PATCH][next] tpm: remove extraneous space after newline \n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ca8a48c-dc5f-4c4d-a829-c94107d852c2@wanadoo.fr>
Date: Tue, 29 Apr 2025 19:00:45 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Colin Ian King <colin.i.king@...il.com>, Peter Huewe <peterhuewe@....de>,
 Jarkko Sakkinen <jarkko@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 linux-integrity@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] tpm: remove extraneous space after newline \n

Le 29/04/2025 à 18:38, Colin Ian King a écrit :
> There is an extraneous space after a \n in a printk statement.
> Remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/char/tpm/eventlog/tpm1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> index 12ee42a31c71..566f4df58d48 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -258,7 +258,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
>   
>   	eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
>   	if (!eventname) {
> -		printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
> +		printk(KERN_ERR "%s: ERROR - No Memory for event name\n",
>   		       __func__);
>   		return -EFAULT;
>   	}

Hi,,

kmalloc() is already verbose, so I think that the whole printk() could 
be removed.

CJ