linux-kernel - Re: [PATCH v2] iwlegacy: 4965: fix possible out-of-bounds access in il4965_tx_cmd_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d57qkj2tj4bgfobgzbhcb4bceh327o35mgamy2yyfuvolg4ymo@7p7hbpyg5bxi>
Date: Tue, 29 Apr 2025 20:15:59 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: Stanislaw Gruszka <stf_xl@...pl>, Alexei Safin <a.safin@...a.ru>
Cc: lvc-project@...uxtesting.org, netdev@...r.kernel.org, 
	Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2] iwlegacy: 4965: fix possible out-of-bounds access in
 il4965_tx_cmd_build_rate()

Hello,

On Sun, 27. Apr 08:39, Stanislaw Gruszka wrote:
> > diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> > index 78dee8ccfebf..f60d9b9798c1 100644
> > --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> > +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> > @@ -1572,7 +1572,7 @@ il4965_tx_cmd_build_rate(struct il_priv *il,
> >  	 */
> >  	rate_idx = info->control.rates[0].idx;
> >  	if ((info->control.rates[0].flags & IEEE80211_TX_RC_MCS) || rate_idx < 0
> > -	    || rate_idx > RATE_COUNT_LEGACY)
> > +	    || rate_idx >= RATE_COUNT_LEGACY)
> >  		rate_idx = rate_lowest_index(&il->bands[info->band], sta);
> 
> .. so looks the check is fine already and changing it will induce a bug
> for RATE_54M_INDEX.
> 
> Regards
> Stanislaw
> 
> >  	/* For 5 GHZ band, remap mac80211 rate indices into driver indices */
> >  	if (info->band == NL80211_BAND_5GHZ)

Here goes the fragment:

		rate_idx += IL_FIRST_OFDM_RATE;
	/* Get PLCP rate for tx_cmd->rate_n_flags */
	rate_plcp = il_rates[rate_idx].plcp;

> > -- 
> > 2.39.5 (Apple Git-154)
> > 

Looks like the proper checks should be added to address the 5GHZ case and
validate that the index won't exceed the array boundaries after being shifted
by IL_FIRST_OFDM_RATE.

--
Thanks,
Fedor