linux-kernel - Re: [PATCH] checkpatch: remove %p4cn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB959739C774BC0CFB20B9735FB8802@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Tue, 29 Apr 2025 23:18:30 +0530
From: Aditya Garg <gargaditya08@...e.com>
To: Joe Perches <joe@...ches.com>, pmladek@...e.com
Cc: admin@...eit.net, airlied@...hat.com, akpm@...ux-foundation.org,
 alyssa@...enzweig.io, andriy.shevchenko@...ux.intel.com, apw@...onical.com,
 asahi@...ts.linux.dev, corbet@....net, dri-devel@...ts.freedesktop.org,
 dwaipayanray1@...il.com, geert@...ux-m68k.org, kees@...nel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux@...musvillemoes.dk, lukas.bulwahn@...il.com, marcan@...can.st,
 mripard@...nel.org, rostedt@...dmis.org, senozhatsky@...omium.org,
 simona@...ll.ch, sven@...npeter.dev, tamird@...il.com, tzimmermann@...e.de
Subject: Re: [PATCH] checkpatch: remove %p4cn



On 29-04-2025 11:05 pm, Joe Perches wrote:
> On Tue, 2025-04-29 at 16:07 +0000, Aditya Garg wrote:
>> %p4cn was recently removed and replaced by %p4chR in vsprintf. So,
>> remove the check for %p4cn from checkpatch.pl.
>>
>> Fixes: 37eed892cc5f ("vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering")
>>
>> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
>> ---
>>  scripts/checkpatch.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 44e233b6f..f79f0a085 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -6891,7 +6891,7 @@ sub process {
>>  					    ($extension eq "f" &&
>>  					     defined $qualifier && $qualifier !~ /^w/) ||
>>  					    ($extension eq "4" &&
>> -					     defined $qualifier && $qualifier !~ /^c[hnlbc]/)) {
>> +					     defined $qualifier && $qualifier !~ /^c[hlbc]/)) {
> 
> Probably needs to be something like:
> 
> 					$qualifier !~ /^c(?:[hlbc]|cR)$/

 					$qualifier !~ /^c(?:[hlbc]|hR)$/
I'll send a v2
> 
>>  						$bad_specifier = $specifier;
>>  						last;
>>  					}
>