linux-kernel - Re: [PATCH] overlayfs: fix potential NULL pointer dereferences in file handle code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1eeea14-4a5c-4f7e-9e54-e552bc1d239f@web.de>
Date: Tue, 29 Apr 2025 20:34:25 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Wang Zhaolong <wangzhaolong1@...wei.com>, linux-unionfs@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Amir Goldstein <amir73il@...il.com>,
 Miklos Szeredi <miklos@...redi.hu>, Yang Erkun <yangerkun@...wei.com>,
 Zhang Yi <yi.zhang@...wei.com>
Subject: Re: [PATCH] overlayfs: fix potential NULL pointer dereferences in
 file handle code

…
> Fix these potential NULL pointer dereferences by adding appropriate NULL
> checks before accessing the file handle structure members.

How do you think about to omit the word “potential” here?

> V1 -> V2:
> - Reworked ovl_verify_fh() …

* You may specify patch version descriptions behind a marker line.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc4#n796

  Please synchronise the version indication in the subject prefix accordingly.

* Would you like to reconsider the assignment also for the variable “err” similarly?

Regards,
Markus