linux-kernel - Re: [PATCH] net: dsa: qca8k: fix led devicename when using external mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6940ad35-1840-4b3b-ae71-27d91f648702@lunn.ch>
Date: Tue, 29 Apr 2025 21:00:05 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: George Moussalem via B4 Relay <devnull+george.moussalem.outlook.com@...nel.org>,
	george.moussalem@...look.com, Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH] net: dsa: qca8k: fix led devicename when using external
 mdio bus

On Tue, Apr 29, 2025 at 11:41:28AM -0700, Jakub Kicinski wrote:
> On Fri, 25 Apr 2025 10:49:55 +0400 George Moussalem via B4 Relay wrote:
> > From: George Moussalem <george.moussalem@...look.com>
> > 
> > The qca8k dsa switch can use either an external or internal mdio bus.
> > This depends on whether the mdio node is defined under the switch node
> > itself and, as such, the internal_mdio_mask is populated with its
> > internal phys. Upon registering the internal mdio bus, the slave_mii_bus
> > of the dsa switch is assigned to this bus. When an external mdio bus is
> > used, it is left unassigned, though its id is used to create the device
> > names of the leds.
> > This leads to the leds being named '(efault):00:green:lan' and so on as
> > the slave_mii_bus is null. So let's fix this by adding a null check and
> > use the devicename of the external bus instead when an external bus is
> > configured.
> 
> Hi Andrew, would you mind taking a quick look?

There is a somewhat ongoing discussion which could affect this:

https://patchwork.kernel.org/project/netdevbpf/patch/20250425151309.30493-1-kabel@kernel.org/

It could well be there is no internal and external MDIO bus, its just
one bus with two bus masters. LED names are somewhere ABI, so i think
we need to resolve the other thread first.

	Andrew