linux-kernel - Re: [PATCH v4 03/12] pinctrl: core: add devm_pinctrl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfM7hw7LLkZ8_oXj2WsWJKyr+yYq38csYYczqNo2qV63A@mail.gmail.com>
Date: Tue, 29 Apr 2025 22:53:00 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Kees Cook <kees@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	thomas.petazzoni@...tlin.com, DanieleCleri@...on.eu, GaryWang@...on.com.tw, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v4 03/12] pinctrl: core: add devm_pinctrl_register_mappings()

On Tue, Apr 29, 2025 at 5:08 PM Thomas Richard
<thomas.richard@...tlin.com> wrote:
>
> Using devm_pinctrl_register_mappings(), the core can automatically
> unregister pinctrl mappings.

...

> +static void devm_pinctrl_unregister_mappings(void *data)

data --> maps

> +{
> +       pinctrl_unregister_mappings(*(const struct pinctrl_map **)data);

Why can't you use the 'maps' pointer directly here?

> +}
> +
> +/**
> + * devm_pinctrl_register_mappings() - Resource managed pinctrl_register_mappings()
> + * @dev: device for which mappings are registered
> + * @maps: the pincontrol mappings table to register. Note the pinctrl-core
> + *     keeps a reference to the passed in maps, so they should _not_ be
> + *     marked with __initdata.
> + * @num_maps: the number of maps in the mapping table

Missing Return: section. Please, validate the kernel doc.

> + */

...

>  void pinctrl_provide_dummies(void);
> +
>  #else

Stray change.


-- 
With Best Regards,
Andy Shevchenko