linux-kernel - Re: [PATCH] rust: device: allow `dead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBE8qQrpXOfru_K3@pollux>
Date: Tue, 29 Apr 2025 22:55:05 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...ts.linux.dev
Subject: Re: [PATCH] rust: device: allow `dead_code` for `Device<>::parent()`

On Tue, Apr 29, 2025 at 09:05:21PM +0200, Miguel Ojeda wrote:
> On Tue, Apr 29, 2025 at 8:15 PM Danilo Krummrich <dakr@...nel.org> wrote:
> >
> > Maybe there is a much better solution I don't know about.
> 
> There is `cfg_attr` for that, and we use it in a couple places, e.g.
> 
>     #[cfg_attr(not(CONFIG_AUXILIARY_BUS), expect(dead_code))]

Well, that is much better, thanks!

I prefer this then, I really want to catch if some other code starts using this.

- Danilo