linux-kernel - Re: [PATCH] nvme-tcp: select tls config when tcp tls is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKmqyKO=Fv8g0+EGFG6LAHqMCvXY2BEaD8ujB=h-SmCyQVnWow@mail.gmail.com>
Date: Wed, 30 Apr 2025 08:04:29 +1000
From: Alistair Francis <alistair23@...il.com>
To: Keith Busch <kbusch@...nel.org>
Cc: Christoph Hellwig <hch@....de>, sagi@...mberg.me, kch@...dia.com, 
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org, hare@...e.de, 
	Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH] nvme-tcp: select tls config when tcp tls is enabled

On Wed, Apr 30, 2025 at 3:42 AM Keith Busch <kbusch@...nel.org> wrote:
>
> On Tue, Apr 29, 2025 at 02:55:05PM +0200, Christoph Hellwig wrote:
> > On Thu, Apr 24, 2025 at 08:13:33PM +1000, Alistair Francis wrote:
> > > Ensure that TLS support is enabled in the kernel when
> > > NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be
> > > used out of the box.
> >
> > How did the code even build before this?
>
> The nvme tls code doesn't appear to use any symbols that depend on
> CONFIG_TLS, so I guess it would compile but wouldn't work at runtime. ?

Yep. It happily builds but then just doesn't work, with no obvious error.

Alistair