linux-kernel - Re: [PATCH net-next v20 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d62e4a57f66cc8462ee1f5ee3491d5f46c650ce.camel@codeconstruct.com.au>
Date: Tue, 29 Apr 2025 12:08:24 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Adam Young <admiyo@...eremail.onmicrosoft.com>, Jonathan Cameron
	 <Jonathan.Cameron@...wei.com>, admiyo@...amperecomputing.com
Cc: Matt Johnston <matt@...econstruct.com.au>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  Sudeep Holla <sudeep.holla@....com>, Huisong
 Li <lihuisong@...wei.com>
Subject: Re: [PATCH net-next v20 1/1] mctp pcc: Implement MCTP over PCC
 Transport

Hi Adam,
> I get a compilation error when I try that:
> 
> drivers/net/mctp/mctp-pcc.c: In function ‘mctp_pcc_client_rx_callback’:
> drivers/net/mctp/mctp-pcc.c:80:30: error: invalid type argument of unary 
> ‘*’ (have ‘struct mctp_pcc_hdr’)
>     80 |                       sizeof(*mctp_pcc_hdr));
> 
> 
> Maybe a compiler flag difference?


In the rx path, `mctp_pcc_hdr` is the struct itself, just drop the
dereference for the push:

    skb_pull(skb, sizeof(mctp_pcc_hdr));

But on tx, mctp_pcc_hdr is a pointer, so:

    mctp_pcc_hdr = skb_push(skb, sizeof(*mctp_pcc_hdr));

Cheers,


Jeremy