linux-kernel - Re: [PATCH bpf-next] libbpf: remove sample_period init in perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a25f585-de46-4e3e-8ec2-47df25947df1@linux.dev>
Date: Tue, 29 Apr 2025 13:48:01 +0800
From: Tao Chen <chen.dylane@...ux.dev>
To: andrii@...nel.org, eddyz87@...il.com, ast@...nel.org,
 daniel@...earbox.net, martin.lau@...ux.dev, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH bpf-next] libbpf: remove sample_period init in perf_buffer

在 2025/4/24 00:39, Tao Chen 写道:

ping...

> It seems that sample_period no used in perf buffer, actually only
> wakeup_events valid about events aggregation for wakeup. So remove
> it to avoid causing confusion.
> 
> Fixes: fb84b8224655 ("libbpf: add perf buffer API")
> Acked-by: Jiri Olsa <jolsa@...nel.org>
> Acked-by: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Tao Chen <chen.dylane@...ux.dev>
> ---
>   tools/lib/bpf/libbpf.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 194809da5172..1830e3c011a5 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -13306,7 +13306,6 @@ struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
>   	attr.config = PERF_COUNT_SW_BPF_OUTPUT;
>   	attr.type = PERF_TYPE_SOFTWARE;
>   	attr.sample_type = PERF_SAMPLE_RAW;
> -	attr.sample_period = sample_period;
>   	attr.wakeup_events = sample_period;
>   
>   	p.attr = &attr;


-- 
Best Regards
Tao Chen