linux-kernel - Re: [PATCH v7 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fdb13dd-6540-471e-9be0-b7248533e522@kernel.org>
Date: Tue, 29 Apr 2025 08:09:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Kees Cook <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Srinivas Kandagatla <srini@...nel.org>
Cc: Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-hardening@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v7 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

On 28/04/2025 13:36, André Draszik wrote:
> +static const struct of_device_id max77759_gpio_of_id[] = {
> +	{ .compatible = "maxim,max77759-gpio", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, max77759_gpio_of_id);
> +
> +static struct platform_driver max77759_gpio_driver = {
> +	.driver = {
> +		.name = "max77759-gpio",
> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> +		.of_match_table = max77759_gpio_of_id,
> +	},
> +	.probe = max77759_gpio_probe,
> +};
> +
> +module_platform_driver(max77759_gpio_driver);
> +
> +MODULE_AUTHOR("André Draszik <andre.draszik@...aro.org>");
> +MODULE_DESCRIPTION("GPIO driver for Maxim MAX77759");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:max77759-gpio");

Drop alias, if you need it means you have incomplete platform ID table
(because it means you will need to add more aliases on every new OF entry).

> 

Best regards,
Krzysztof