linux-kernel - Re: [PATCH next] misc: ti_fpc202: Fix off by one in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <krkppjdlgtcc7h7pg4e7vvwe46hu44jv2cngp3g63dx55rrbdb@frztorpfnfdf>
Date: Tue, 29 Apr 2025 08:16:02 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Romain Gantois <romain.gantois@...tlin.com>, 
	Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] misc: ti_fpc202: Fix off by one in probe()

Hi Dan,

On Wed, Apr 23, 2025 at 11:22:30AM +0300, Dan Carpenter wrote:
> The "port_id" is used as an array index into the struct fpc202_priv
> priv->addr_caches[] array in fpc202_write_dev_addr().  It's a 2 by 2
> array so if "port_id" is FPC202_NUM_PORTS (2) then it's one element
> out of bounds.  Change the > to >= to fix this bug.
> 
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Thanks,
Andi