linux-kernel - Re: [PATCH v2 4/9] block: cleanup blk_mq_in_flight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f140d8b-6a2a-41af-ba73-0963713f211e@suse.de>
Date: Tue, 29 Apr 2025 08:31:02 +0200
From: Hannes Reinecke <hare@...e.de>
To: Yu Kuai <yukuai1@...weicloud.com>, hch@...radead.org, axboe@...nel.dk,
 xni@...hat.com, agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com,
 song@...nel.org, yukuai3@...wei.com, cl@...ux.com, nadav.amit@...il.com,
 ubizjak@...il.com, akpm@...ux-foundation.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH v2 4/9] block: cleanup blk_mq_in_flight_rw()

On 4/27/25 10:29, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> Also add comment for part_inflight_show() for the difference between
> bio-based and rq-based device.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>   block/blk-mq.c | 12 ++++++------
>   block/blk-mq.h |  3 +--
>   block/genhd.c  | 43 +++++++++++++++++++++++++------------------
>   3 files changed, 32 insertions(+), 26 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 301dbd3e1743..0067e8226e05 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -89,7 +89,7 @@ struct mq_inflight {
>   	unsigned int inflight[2];
>   };
>   
> -static bool blk_mq_check_inflight(struct request *rq, void *priv)
> +static bool blk_mq_check_in_driver(struct request *rq, void *priv)

Please don't rename these functions. 'in flight' always means 'in flight
in the driver', so renaming them just introduces churn with no real 
advantage.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich