linux-kernel - Re: [PATCH] i2c: imx-lpi2c: Fix clock count when probe defers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yk4jxzsraqacrzinn34bvpalmnqxfyxrxch7buz62olt6allcx@rqda6tysnbhh>
Date: Tue, 29 Apr 2025 10:01:27 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Carlos Song <carlos.song@....com>
Cc: Aisheng Dong <aisheng.dong@....com>, Frank Li <frank.li@....com>, 
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, 
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, 
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: imx-lpi2c: Fix clock count when probe defers

Hi Carlos,

...

> > > > > Signed-off-by: Carlos Song <carlos.song@....com>
> > > > > Signed-off-by: Clark Wang <xiaoning.wang@....com>
> > > > > Signed-off-by: Jun Li <jun.li@....com>
> > > > > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > > >
> > > > Carlo's SoB should be at the end of the chain. Should be nice to
> > > > know what these are, though, are they co-developed-by? tested-by?
> > > > Why so many SoB's?
> > > >
> > >
> > > This patch author is not me and they meet similar issue at some
> > > boards(Vague history), now I meet this issue at new SOC again. I think this local
> > patch is helpful and looks reasonable.
> > > So I send the patch to community adding my SoB.
> > 
> > So Clark has authored the patch and you have sent it. And your SoB makes sense
> > (even though, your SoB shoud be placed at the end, because you sent the
> > patch).
> > 
> > Juan and Haibo have tested it? Reported it?
> > 
> 
> They are local reviewer. So I change their Reviewed-by: to Signed-off-by:.
> Simply you can remove Jun and Haibo tags only keep two tags:

I see. Jun and Haibo are welcome to review in this list, if they
want.

> Signed-off-by: Carlos Song <carlos.song@....com>
> Signed-off-by: Clark Wang <xiaoning.wang@....com>

Following the chronological order concept, it would be:

Signed-off-by: Clark Wang <xiaoning.wang@....com>
Signed-off-by: Carlos Song <carlos.song@....com>

:-)

I'll take care of it.

Thanks,
Andi