linux-kernel - Re: [net-next v8 4/7] net: mtip: The L2 switch driver for imx287

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250429101938.54790e51@wsk>
Date: Tue, 29 Apr 2025 10:19:38 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Richard Cochran
 <richardcochran@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, Stefan Wahren
 <wahrenst@....net>, Simon Horman <horms@...nel.org>, Andrew Lunn
 <andrew@...n.ch>
Subject: Re: [net-next v8 4/7] net: mtip: The L2 switch driver for imx287

Hi Jakub,

> On Mon, 28 Apr 2025 09:44:21 +0200 Lukasz Majewski wrote:
> > This patch series provides support for More Than IP L2 switch
> > embedded in the imx287 SoC.
> > 
> > This is a two port switch (placed between uDMA[01] and MAC-NET[01]),
> > which can be used for offloading the network traffic.
> > 
> > It can be used interchangeably with current FEC driver - to be more
> > specific: one can use either of it, depending on the requirements.
> > 
> > The biggest difference is the usage of DMA - when FEC is used,
> > separate DMAs are available for each ENET-MAC block.
> > However, with switch enabled - only the DMA0 is used to
> > send/receive data to/form switch (and then switch sends them to
> > respecitive ports).
> > 
> > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> > Reviewed-by: Stefan Wahren <wahrenst@....net>
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>  
> 
> Linking fails with allmodconfig
> 
> ERROR: modpost: missing MODULE_LICENSE() in
> drivers/net/ethernet/freescale/mtipsw/mtipl2sw_mgnt.o WARNING:
> modpost: missing MODULE_DESCRIPTION() in
> drivers/net/ethernet/freescale/mtipsw/mtipl2sw_mgnt.o ERROR: modpost:
> missing MODULE_LICENSE() in
> drivers/net/ethernet/freescale/mtipsw/mtipl2sw_br.o WARNING: modpost:
> missing MODULE_DESCRIPTION() in
> drivers/net/ethernet/freescale/mtipsw/mtipl2sw_br.o ERROR: modpost:
> "mtip_forced_forward"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_port_learning_config"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_port_blocking_config"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_port_enable_config"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_port_broadcast_config"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_port_multicast_config"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_switch_en_port_separation"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_register_notifiers"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_unregister_notifiers"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw.ko] undefined! ERROR:
> modpost: "mtip_is_switch_netdev_port"
> [drivers/net/ethernet/freescale/mtipsw/mtipl2sw_br.ko] undefined!
> WARNING: modpost: suppressed 3 unresolved symbol warnings because
> there were too many)

Yes, you are right.

I've adjusted makefile to build it properly as a module.

Thanks for spotting it.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped