linux-kernel - Re: [PATCH v5 1/3] clocksource/drivers/timer-tegra186: add WDIOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbb3a1b3-3949-402a-b51c-f5446a392e83@nvidia.com>
Date: Tue, 29 Apr 2025 10:15:18 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Robert Lin <robelin@...dia.com>
Cc: thierry.reding@...il.com, tglx@...utronix.de, pohsuns@...dia.com,
 linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, sumitg@...dia.com
Subject: Re: [PATCH v5 1/3] clocksource/drivers/timer-tegra186: add
 WDIOC_GETTIMELEFT support

Hi Daniel,

On 29/04/2025 09:59, Daniel Lezcano wrote:
> On Mon, Apr 21, 2025 at 06:08:19PM +0800, Robert Lin wrote:
>> From: Pohsun Su <pohsuns@...dia.com>
>>
>> This change adds support for WDIOC_GETTIMELEFT so userspace
>> programs can get the number of seconds before system reset by
>> the watchdog timer via ioctl.
>>
>> Signed-off-by: Pohsun Su <pohsuns@...dia.com>
>> Signed-off-by: Robert Lin <robelin@...dia.com>
>> ---
> 
> Hi Robert,
> 
> I realize that this driver should be split in two and the watchdog part go
> under drivers/watchdog.

Are there any other examples you know of where the timer is split in 
this way? It is not clear to me how you propose we do this?

BTW, for this series, I just want to get these updates merged. Any other 
re-factoring we can handle later.

Cheers!
Jon

-- 
nvpublic