linux-kernel - Re: [PATCH v2] rust: page:: optimize rust symbol generation for Page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH5fLgiqFWs+Mw+8AYOOx83A6vQGYaaPJ1RbCZFEKALabLxDiw@mail.gmail.com>
Date: Tue, 29 Apr 2025 11:15:37 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Kunwu Chan <kunwu.chan@...ux.dev>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, 
	a.hindborg@...nel.org, tmgross@...ch.edu, dakr@...nel.org, nathan@...nel.org, 
	nick.desaulniers+lkml@...il.com, morbo@...gle.com, justinstitt@...gle.com, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev, Kunwu Chan <kunwu.chan@...mail.com>, 
	Grace Deng <Grace.Deng006@...il.com>
Subject: Re: [PATCH v2] rust: page:: optimize rust symbol generation for Page

On Fri, Mar 21, 2025 at 9:02 AM Kunwu Chan <kunwu.chan@...ux.dev> wrote:
>
> From: Kunwu Chan <kunwu.chan@...mail.com>
>
> When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64
> with ARCH=arm64, the following symbols are generated:
>
> $nm vmlinux | grep ' _R'.*Page | rustfilt
> ffff8000805b6f98 T <kernel::page::Page>::alloc_page
> ffff8000805b715c T <kernel::page::Page>::fill_zero_raw
> ffff8000805b720c T <kernel::page::Page>::copy_from_user_slice_raw
> ffff8000805b6fb4 T <kernel::page::Page>::read_raw
> ffff8000805b7088 T <kernel::page::Page>::write_raw
> ffff8000805b72fc T <kernel::page::Page as core::ops::drop::Drop>::drop
>
> These Rust symbols(alloc_page and drop) are trivial wrappers around the C
> functions alloc_pages and __free_pages. It doesn't make sense to go
> through a trivial wrapper for these functions, so mark them inline.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1145
> Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
> Co-developed-by: Grace Deng <Grace.Deng006@...il.com>
> Signed-off-by: Grace Deng <Grace.Deng006@...il.com>
> Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>