linux-kernel - Re: [PATCH v3] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174591879227.993707.10510220720735935886.b4-ty@bootlin.com>
Date: Tue, 29 Apr 2025 11:26:32 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: richard@....at, vigneshr@...com, Wentao Liang <vulab@...as.ac.cn>
Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mtd: bcm47xxnflash: Add error handling for
 bcm47xxnflash_ops_bcm4706_ctl_cmd()

On Mon, 07 Apr 2025 17:43:47 +0800, Wentao Liang wrote:
> The function bcm47xxnflash_ops_bcm4706_cmd_ctrl() calls the function
> bcm47xxnflash_ops_bcm4706_ctl_cmd(), but does not check its return value.
> A proper implementation can be found in bcm47xxnflash_ops_bcm4706_write().
> 
> Add error log to the bcm47xxnflash_ops_bcm4706_ctl_cmd() via pr_err()
> to prevent silent failure. The error Log funciton 'dev_err' is unsuitable
> in this situation for it is hard to get device pointer.
> 
> [...]

Applied to nand/next, thanks!

[1/1] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd()
      commit: 00b102d9e3827fabad366e464512a34f97406389

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl