linux-kernel - Re: [PATCH net-next v9 07/13] net: pse-pd: Add support for budget evaluation strategies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60643797-2466-4200-9abe-9956bfdeaa73@redhat.com>
Date: Tue, 29 Apr 2025 11:30:32 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kory Maincent <kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
 Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Jonathan Corbet <corbet@....net>,
 Donald Hunter <donald.hunter@...il.com>, Rob Herring <robh@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>,
 Dent Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v9 07/13] net: pse-pd: Add support for budget
 evaluation strategies

On 4/22/25 4:56 PM, Kory Maincent wrote:
> @@ -223,6 +237,17 @@ struct pse_pi_pairset {
>   * @rdev: regulator represented by the PSE PI
>   * @admin_state_enabled: PI enabled state
>   * @pw_d: Power domain of the PSE PI
> + * @prio: Priority of the PSE PI. Used in static budget evaluation strategy
> + * @isr_pd_detected: PSE PI detection status managed by the interruption
> + *		     handler. This variable is relevant when the power enabled
> + *		     management is managed in software like the static
> + *		     budget evaluation strategy.
> + * @pw_allocated_mW: Power allocated to a PSE PI to manage power budget in
> + *		     static budget evaluation strategy.
> + * @_isr_counter_mismatch: Internal flag used in PSE core in case of a
> + *			   counter mismatch between regulator and PSE API.
> + *			   This is caused by a disable call in the interrupt
> + *			   context handler.

The name itself of this field is somewhat concerning, and I don't see it
set to any nonzero value here or in later patches.

Possibly it should be removed entirely???

/P