linux-kernel - Re: [PATCH v2] nvmem: zynqmp_nvmem: unbreak driver after cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99d29701-6257-42bf-a1c4-1707c3eb54c1@amd.com>
Date: Tue, 29 Apr 2025 12:04:40 +0200
From: Michal Simek <michal.simek@....com>
To: Peter Korsgaard <peter@...sgaard.com>,
 Praveen Teja Kundanala <praveen.teja.kundanala@....com>,
 Kalyani Akula <kalyani.akula@....com>, Srinivas Kandagatla
 <srini@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: stable@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvmem: zynqmp_nvmem: unbreak driver after cleanup



On 4/22/25 16:21, Peter Korsgaard wrote:
> Commit 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
> changed the driver to expect the device pointer to be passed as the
> "context", but in nvmem the context parameter comes from nvmem_config.priv
> which is never set - Leading to null pointer exceptions when the device is
> accessed.
> 
> Fixes: 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
> Cc: stable@...r.kernel.org
> Signed-off-by: Peter Korsgaard <peter@...sgaard.com>
> ---
> Changes since v1:
> - Cc stable
> 
>   drivers/nvmem/zynqmp_nvmem.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
> index 8682adaacd692..7da717d6c7faf 100644
> --- a/drivers/nvmem/zynqmp_nvmem.c
> +++ b/drivers/nvmem/zynqmp_nvmem.c
> @@ -213,6 +213,7 @@ static int zynqmp_nvmem_probe(struct platform_device *pdev)
>   	econfig.word_size = 1;
>   	econfig.size = ZYNQMP_NVMEM_SIZE;
>   	econfig.dev = dev;
> +	econfig.priv = dev;
>   	econfig.add_legacy_fixed_of_cells = true;
>   	econfig.reg_read = zynqmp_nvmem_read;
>   	econfig.reg_write = zynqmp_nvmem_write;

Reviewed-by: Michal Simek <michal.simek@....com>
Tested-by: Michal Simek <michal.simek@....com>

Thanks,
Michal