linux-kernel - Re: [PATCH -next] mmc: sdhci-esdhc-imx: fix defined but not used warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFr3EN+Ss5qaFmQ1+42=t_cZ55PtggXMq8uVHPkYQy-uyw@mail.gmail.com>
Date: Tue, 29 Apr 2025 12:06:30 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Luke Wang <ziniu.wang_1@....com>, 
	linux-mmc@...r.kernel.org, Haibo Chen <haibo.chen@....com>, imx@...ts.linux.dev, 
	s32@....com
Subject: Re: [PATCH -next] mmc: sdhci-esdhc-imx: fix defined but not used warnings

On Thu, 24 Apr 2025 at 05:46, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Fix warnings when CONFIG_PM=y and CONFIG_PM_SLEEP is not set by
> surrounding the 2 functions with #ifdef CONFIG_PM_SLEEP.
>
> drivers/mmc/host/sdhci-esdhc-imx.c:1659:13: warning: 'sdhc_esdhc_tuning_restore' defined but not used [-Wunused-function]
>  1659 | static void sdhc_esdhc_tuning_restore(struct sdhci_host *host)
> drivers/mmc/host/sdhci-esdhc-imx.c:1637:13: warning: 'sdhc_esdhc_tuning_save' defined but not used [-Wunused-function]
>  1637 | static void sdhc_esdhc_tuning_save(struct sdhci_host *host)
>
> Fixes: 3d1eea493894 ("mmc: sdhci-esdhc-imx: Save tuning value when card stays powered in suspend")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Luke Wang <ziniu.wang_1@....com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: linux-mmc@...r.kernel.org
> Cc: Haibo Chen <haibo.chen@....com>
> Cc: imx@...ts.linux.dev
> Cc: s32@....com

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- linux-next-20250423.orig/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ linux-next-20250423/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1634,6 +1634,7 @@ static void sdhci_esdhc_imx_hwinit(struc
>         }
>  }
>
> +#ifdef CONFIG_PM_SLEEP
>  static void sdhc_esdhc_tuning_save(struct sdhci_host *host)
>  {
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> @@ -1688,6 +1689,7 @@ static void sdhc_esdhc_tuning_restore(st
>                        host->ioaddr + ESDHC_TUNE_CTRL_STATUS);
>         }
>  }
> +#endif
>
>  static void esdhc_cqe_enable(struct mmc_host *mmc)
>  {