linux-kernel - Re: [PATCH] spi: spi-qpic-snand: fix NAND_READ_LOCATION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab24fa96-8c2a-8be3-bcb2-f31e9e6f1ec6@quicinc.com>
Date: Tue, 29 Apr 2025 15:50:31 +0530
From: Md Sadre Alam <quic_mdalam@...cinc.com>
To: Gabor Juhos <j4g8y7@...il.com>, Mark Brown <broonie@...nel.org>,
        "Sricharan Ramabadhran" <quic_srichara@...cinc.com>,
        Varadarajan Narayanan
	<quic_varada@...cinc.com>
CC: <linux-spi@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spi-qpic-snand: fix NAND_READ_LOCATION_2 register
 handling



On 4/28/2025 1:00 PM, Gabor Juhos wrote:
> The precomputed value for the NAND_READ_LOCATION_2 register should be
> stored in 'snandc->regs->read_location2'.
> 
> Fix the qcom_spi_set_read_loc_first() function accordingly.
> 
> Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> ---
>   drivers/spi/spi-qpic-snand.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
> index ae32c452d0bcf852b69b76e595f3588ea7e1a670..94948c8781e83f30650e5fbac56897daf5eb3c2c 100644
> --- a/drivers/spi/spi-qpic-snand.c
> +++ b/drivers/spi/spi-qpic-snand.c
> @@ -142,7 +142,7 @@ static void qcom_spi_set_read_loc_first(struct qcom_nand_controller *snandc,
>   	else if (reg == NAND_READ_LOCATION_1)
>   		snandc->regs->read_location1 = locreg_val;
>   	else if (reg == NAND_READ_LOCATION_2)
> -		snandc->regs->read_location1 = locreg_val;
> +		snandc->regs->read_location2 = locreg_val;
>   	else if (reg == NAND_READ_LOCATION_3)
>   		snandc->regs->read_location3 = locreg_val;
>   }
> 
> ---
> base-commit: 15cfe55ec58ace931a73e19e5367598734ceb074
> change-id: 20250428-qpic-snand-readloc2-fix-bccd07cf26d3

Reviewed-by: Md Sadre Alam <quic_mdalam@...cinc.com>

> 
> Best regards,