linux-kernel - Re: [PATCH] mm, swap: fix false warning for large allocation with !THP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250429100831.8629C3b-hca@linux.ibm.com>
Date: Tue, 29 Apr 2025 12:08:31 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Kairui Song <kasong@...cent.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm, swap: fix false warning for large allocation with
 !THP_SWAP

On Tue, Apr 29, 2025 at 05:48:03PM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> The !CONFIG_THP_SWAP check existed before just fine because slot
> cache would reject high order allocation and let the caller split
> all folios and try again.
> 
> But slot cache is gone, so large allocation will directly go
> to the allocator, and the allocator should just fail silently
> to inform caller to do the folio split, this is totally fine
> and expected.
> 
> Remove this meaning less warning.
> 
> Fixes: 0ff67f990bd4 ("mm, swap: remove swap slot cache")
> Reported-by: Heiko Carstens <hca@...ux.ibm.com>
> Closes: https://lore.kernel.org/linux-mm/20250428135252.25453B17-hca@linux.ibm.com/
> Signed-off-by: Kairui Song <kasong@...cent.com>
> ---
>  mm/swapfile.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)

Tested-by: Heiko Carstens <hca@...ux.ibm.com>