linux-kernel - Re: [PATCH] pinctrl: intel: Document Tiger Lake reuse on some Alder Lake platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VccaDdzW7SUyLE6Y+HLFDHdcc78JZTFD5wbAeOOdPEqOA@mail.gmail.com>
Date: Tue, 29 Apr 2025 13:59:20 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Ariel Simulevski <ariel@...ulevski.at>
Cc: andy@...nel.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: intel: Document Tiger Lake reuse on some Alder
 Lake platforms

On Tue, Apr 29, 2025 at 2:56 AM Ariel Simulevski <ariel@...ulevski.at> wrote:

Thank you for the patch. My comments below.

First of all, the Subject should start with: "pinctrl: tigerlake: ..."

> Some Alder Lake systems, such as those using the PixArt I2C touchpad (PIXA3848),
> reuse GPIO IP blocks similar to Tiger Lake. As a result, enabling
> CONFIG_PINCTRL_TIGERLAKE may be required for proper I2C device detection.
>
> Document this in the Kconfig help text to assist users encountering this issue.

It's all nice, but can be written in much simpler way:

"Some users may be confused on what to choose to support their chipsets,
Document supported SoCs and PCHs by the driver in the Kconfig help text."

Or something like that.

(In other words the "touchpad", "some systems", etc are unneeded
details. It may be other users who have different issues, you need to
cover all of them.)

> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220056

> Signed-off-by: Ariel Simulevski <ariel@...ulevski.at>

Reported-by: ... ?

...

> @@ -54,6 +54,11 @@ config PINCTRL_ALDERLAKE
>           This pinctrl driver provides an interface that allows configuring
>           of Intel Alder Lake PCH pins and using them as GPIOs.
>
> +         Note: On some Alder Lake platforms, including systems with
> +         the PixArt I2C touchpad (PIXA3848), the hardware reuses
> +         Tiger Lake style GPIO blocks. For proper device detection,
> +         enabling CONFIG_PINCTRL_TIGERLAKE may be necessary.
> +

This is too narrow and too detailed, nobody needs to know this. Just
list the platforms the driver supports (take the example from the
existing list, i.e. INTEL_PLATFORM):
"Currently the following Intel SoCs / platforms require this to be functional:
  — Tiger Lake (all variants) // needs to be double checked
  — Alder Lake-P
"

-- 
With Best Regards,
Andy Shevchenko