linux-kernel - Re: [PATCH] net/mlx4_core: Adjust allocation type for buddy->bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c805775c-9729-4090-9d09-eec9b14874e6@gmail.com>
Date: Tue, 29 Apr 2025 14:23:30 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Kees Cook <kees@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] net/mlx4_core: Adjust allocation type for buddy->bits



On 26/04/2025 9:07, Kees Cook wrote:
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> The assigned type is "unsigned long **", but the returned type will be
> "long **". These are the same size allocation (pointer size) but the
> types do not match. Adjust the allocation type to match the assignment.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Tariq Toukan <tariqt@...dia.com>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: <netdev@...r.kernel.org>
> Cc: <linux-rdma@...r.kernel.org>
> ---
>   drivers/net/ethernet/mellanox/mlx4/mr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mr.c b/drivers/net/ethernet/mellanox/mlx4/mr.c
> index d7444782bfdd..698a5d1f0d7e 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mr.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mr.c
> @@ -106,7 +106,7 @@ static int mlx4_buddy_init(struct mlx4_buddy *buddy, int max_order)
>   	buddy->max_order = max_order;
>   	spin_lock_init(&buddy->lock);
>   
> -	buddy->bits = kcalloc(buddy->max_order + 1, sizeof(long *),
> +	buddy->bits = kcalloc(buddy->max_order + 1, sizeof(*buddy->bits),
>   			      GFP_KERNEL);
>   	buddy->num_free = kcalloc(buddy->max_order + 1, sizeof(*buddy->num_free),
>   				  GFP_KERNEL);

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks.