linux-kernel - Re: [PATCH v2] rust: kernel: device: Add devm_of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nkPW3oG8bzxV_=dqNFTDAiMr+viRE9ttG8P1d3Ug7vzg@mail.gmail.com>
Date: Tue, 29 Apr 2025 14:10:51 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Ayush Singh <ayush@...gleboard.org>
Cc: Jason Kridner <jkridner@...gleboard.org>, Deepak Khatri <lorforlinux@...gleboard.org>, 
	Robert Nelson <robertcnelson@...gleboard.org>, Dhruva Gole <d-gole@...com>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust: kernel: device: Add devm_of_platform_populate/depopulate

On Tue, Apr 29, 2025 at 1:41 PM Ayush Singh <ayush@...gleboard.org> wrote:
>
> +    /// Populate platform_devices from device tree data
> +    pub fn devm_of_platform_populate(&self) -> crate::error::Result<()> {
> +        // SAFETY: self is valid bound Device reference

If you import the prelude, then you could use just `Result`. Also,
please try to follow the style of the rest of the code, e.g. use
Markdown in both comments and documentation and finish sentences with
a period.

Thanks!

Cheers,
Miguel