linux-kernel - Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17c35382-36c2-44e6-b553-e66a32a8c47e@csgroup.eu>
Date: Tue, 29 Apr 2025 13:58:38 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Ioana Ciornei <ioana.ciornei@....com>,
 Thorsten Blum <thorsten.blum@...ux.dev>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of
 strscpy_pad()



Le 29/04/2025 à 13:47, Ioana Ciornei a écrit :
> On Tue, Apr 29, 2025 at 12:41:48PM +0200, Thorsten Blum wrote:
>> Both destination buffers are already zero-initialized, making strscpy()
>> sufficient for safely copying 'obj_type'. The additional NUL-padding
>> performed by strscpy_pad() is unnecessary.
>>
>> If the destination buffer has a fixed length, strscpy() automatically
>> determines its size using sizeof() when the argument is omitted. This
>> makes the explicit size arguments unnecessary.
>>
>> No functional changes intended.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> 
> Reviewed-by: Ioana Ciornei <ioana.ciornei@....com>
> 
> Christophe, could you also pick-up this patch when you have a chance?
> 

Sure I will take it when time comes, but again I'd expect an explanation 
inside the patch (below the ---) for the resend. I now have this patch 
twice in the list and don't know why, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=&submitter=&state=&q=&archive=&delegate=61610

Christophe