linux-kernel - Re: [PATCH v2] xfs: allow ro mounts if rtdev or logdev are read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250430124345.GA32269@lst.de>
Date: Wed, 30 Apr 2025 14:43:46 +0200
From: hch <hch@....de>
To: Hans Holmberg <Hans.Holmberg@....com>
Cc: Carlos Maiolino <cem@...nel.org>, Dave Chinner <david@...morbit.com>,
	"Darrick J . Wong" <djwong@...nel.org>, hch <hch@....de>,
	"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] xfs: allow ro mounts if rtdev or logdev are
 read-only

On Wed, Apr 30, 2025 at 08:35:34AM +0000, Hans Holmberg wrote:
> +	blk_mode_t		mode;
>  
> -	*bdev_filep = bdev_file_open_by_path(name,
> -		BLK_OPEN_READ | BLK_OPEN_WRITE | BLK_OPEN_RESTRICT_WRITES,
> -		mp->m_super, &fs_holder_ops);
> +	mode = sb_open_mode(mp->m_super->s_flags);
> +	*bdev_filep = bdev_file_open_by_path(name, mode,
> +			mp->m_super, &fs_holder_ops);

We don't really need the local variable for mode now.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>