linux-kernel - Re: [PATCH v3 3/5] dt-bindings: power: supply: add max77759-fg flavor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a781a7bc-5dcb-4d28-9997-87404fa8c675@uclouvain.be>
Date: Wed, 30 Apr 2025 15:51:33 +0200
From: Thomas Antoine <t.antoine@...ouvain.be>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Peter Griffin <peter.griffin@...aro.org>,
 André Draszik <andre.draszik@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Sebastian Reichel <sre@...nel.org>, Dimitri Fedrau <dima.fedrau@...il.com>,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 3/5] dt-bindings: power: supply: add max77759-fg flavor

Hello,

On 4/23/25 15:45, Krzysztof Kozlowski wrote:
> On 23/04/2025 10:05, Thomas Antoine wrote:
>> On 4/22/25 12:05, Krzysztof Kozlowski wrote:
>>> On Mon, Apr 21, 2025 at 08:13:34PM GMT, Thomas Antoine wrote:
>>>> +allOf:
>>>> +  - $ref: power-supply.yaml#
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - maxim,max17201
>>>> +    then:
>>>> +      properties:
>>>> +        reg:
>>>> +          minItems: 2
>>>> +          maxItems: 2
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - maxim,max77759-fg
>>>> +    then:
>>>> +      properties:
>>>> +        reg:
>>>> +          items:
>>>> +            minItems: 1
>>> If there is going to be resend, drop minItems.
>>>
>> Will drop it in v4.
>>
> One more thing - your reg-names are now incorrectly constrained - where
> are their constraints?
> 
> You need to test your bindings and DTS before you post. If by any chance
> community robots found more issues (e.g. you sent something untested),
> you should address it.
> 
> 
> Best regards,
> Krzysztof

I did run the test but I obviously must have done it wrong. I will check it out
such that it does not happen again.

Best regards,
Thomas