linux-kernel - Re: [PING PATCH v3] perf test: Allow tolerance for leader sampling test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <273daacc-4a82-41d0-bb8e-af28540868ec@linux.ibm.com>
Date: Wed, 30 Apr 2025 16:00:21 +0200
From: Thomas Richter <tmricht@...ux.ibm.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-perf-users@...r.kernel.org, namhyung@...nel.org,
        ctshao@...gle.com, irogers@...gle.com, agordeev@...ux.ibm.com,
        gor@...ux.ibm.com, sumanthk@...ux.ibm.com, hca@...ux.ibm.com
Subject: Re: [PING PATCH v3] perf test: Allow tolerance for leader sampling
 test

On 4/30/25 14:56, Arnaldo Carvalho de Melo wrote:
> On Tue, Apr 22, 2025 at 01:06:43PM +0200, Thomas Richter wrote:
>> V3: Added check for missing samples as suggested by Chun-Tse.
>> V2: Changed bc invocation to return 0 on success and 1 on error.
>  
>> There is a known issue that the leader sampling is inconsistent, since
>> throttle only affect leader, not the slave. The detail is in [1]. To
>> maintain test coverage, this patch sets a tolerance rate of 80% to
>> accommodate the throttled samples and prevent test failures due to
>> throttling.
>  
>> [1] lore.kernel.org/20250328182752.769662-1-ctshao@...gle.com
>  
>> Signed-off-by: Chun-Tse Shao <ctshao@...gle.com>
>> Suggested-by: Ian Rogers <irogers@...gle.com>
>> Suggested-by: Thomas Richter <tmricht@...ux.ibm.com>
>> Tested-by: Thomas Richter <tmricht@...ux.ibm.com>
>> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> 
> This doesn't apply to perf-tools-next:
> 
> ⬢ [acme@...lbx perf-tools-next]$        git am ./v3_20250422_tmricht_perf_test_allow_tolerance_for_leader_sampling_test.mbx
> Applying: perf test: Allow tolerance for leader sampling test
> error: patch failed: tools/perf/tests/shell/record.sh:238
> error: tools/perf/tests/shell/record.sh: patch does not apply
> Patch failed at 0001 perf test: Allow tolerance for leader sampling test
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config set advice.mergeConflict false"
> ⬢ [acme@...lbx perf-tools-next]$
> 
> Are you proposing this for perf-tools, i.e. for this release cycles?
> 
> Namhyung, what do you think?
> 
>

It would be good if this could go onto linux-next. However I noticed
this patch does not apply anymore on that tree. I will send updated
patch as version 4.

Thanks a lot

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294