linux-kernel - Re: [PATCH] scsi: sd_zbc: Limit the report zones buffer size to UIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBIucgM0vrlfE2f9@infradead.org>
Date: Wed, 30 Apr 2025 07:06:42 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Damien Le Moal <dlemoal@...nel.org>
Cc: "Siwinski, Steve" <ssiwinski@...o.com>,
	Christoph Hellwig <hch@...radead.org>, bgrove@...o.com,
	James.Bottomley@...senpartnership.com, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
	Steve Siwinski <stevensiwinski@...il.com>
Subject: Re: [PATCH] scsi: sd_zbc: Limit the report zones buffer size to
 UIO_MAXIOV

On Fri, Apr 25, 2025 at 10:42:46AM +0900, Damien Le Moal wrote:
> and the fact that bio_kmalloc() does not allow more than UIO_MAXIOV segments
> would have made things clear from the beginning. I had to look it up again to
> understand why UIO_MAXIOV matters.

We shouldn't really allow mapping unlimited number of segments.
So the original patch looks mostly fine, except that we should
really replace that UIO_MAXIOV symbolic name with a more descriptive
one in the block layer, keeping the same value for it.